Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Matrices stored in row-major order #47

Closed
nic-barbara opened this issue Aug 28, 2023 · 1 comment · Fixed by #48
Closed

Matrices stored in row-major order #47

nic-barbara opened this issue Aug 28, 2023 · 1 comment · Fixed by #48
Milestone

Comments

@nic-barbara
Copy link
Collaborator

nic-barbara commented Aug 28, 2023

All the matrices in the Model and Data objects are currently stored in row-major form in stead of column-major like other arrays in Julia. This means that the elements are not in the correct order, which will cause confusion and make usability much less neat. Can we find a nice way around this?

@nic-barbara
Copy link
Collaborator Author

nic-barbara commented Aug 28, 2023

For now, users can do something like

row2col(M::AbstractMatrix) = transpose(reshape(M, size(M, 2), size(M, 1)))

when they need to access any matrices in the model or data structs, but we should have a better solution.

@nic-barbara nic-barbara added this to the initial-beta milestone Aug 28, 2023
@JamieMair JamieMair linked a pull request Aug 28, 2023 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant