Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(jans-pycloudlib): add AWS Secrets Manager support for configuration layers #3112

Merged
merged 4 commits into from
Nov 30, 2022
Merged

feat(jans-pycloudlib): add AWS Secrets Manager support for configuration layers #3112

merged 4 commits into from
Nov 30, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 29, 2022 •
edited
Loading

Prepare

Description

Target issue

closes #3026

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner November 29, 2022 17:23
@sonarqubecloud
Copy link

[jans-pycloudlib] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
27.5% 27.5% Duplication

@iromli
Copy link
Contributor Author

iromli commented Nov 29, 2022

[jans-pycloudlib] SonarCloud Quality Gate failed. Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 0 Code Smells

0.0% 0.0% Coverage 27.5% 27.5% Duplication

The duplication can be ignored for now.

@mo-auto
chore(jans-pycloudlib): updated build (#3113)
583b0a1 
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
@sonarqubecloud
Copy link

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu moabu merged commit 0522e61 into main Nov 30, 2022
@moabu moabu deleted the cn-aws-secretsmanager branch November 30, 2022 13:47
This was referenced Dec 1, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@mo-auto2 mo-auto2 mentioned this pull request Dec 1, 2022
Merged
This was referenced Dec 1, 2022
Merged
Merged
This was referenced Jan 9, 2023
Merged
Merged
Merged
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-auth-server comp-docker-jans-certmanager comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-persistence-loader comp-docker-jans-scim comp-jans-pycloudlib kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-pycloudlib): add AWS secret manager support as a secret layer for holding CN configuration
3 participants
@iromli @moabu @mo-auto