Merge pull request #5 from Jbguerin13/test-booking-page

feat: test booking page

Author: Jbguerin13

server.py

@@ -30,13 +30,18 @@ def index():
 @app.route('/show_summary',methods=['POST','GET'])
 def show_summary():
     email = request.form.get("email") if request.method == "POST" else request.args.get("email")
+    
+    if not email:
+        flash("Email is required. Please login.", "error")
+        return redirect(url_for('index'))
+
     club = next((club for club in clubs if club['email'] == email), None)
 
     if club:
         return render_template('welcome.html', club=club, competitions=competitions)
 
     flash("Wrong credentials, please retry", "error")
-    return redirect(url_for('index')), 400
+    return redirect(url_for('index'))
 
 #display the booking page
 @app.route('/book/<competition>/<club>', methods=['GET', 'POST'])

tests/test_booking_page.py

@@ -0,0 +1,8 @@
+import pytest
+
+def test_booking_page_when_club_not_found(client, setup_data):
+    """TEST: The booking page should load when credentials are correct"""
+    response = client.get('/book/Competition 5/Club D', follow_redirects=True)
+
+    assert response.status_code == 200
+    assert b"Something went wrong - Please try again" in response.data

tests/test_purchase_place.py

@@ -12,7 +12,7 @@ def test_purchase_places_success(client, setup_data):
     assert response.status_code == 302
     assert int(competitions[0]['numberOfPlaces']) == 15
 
-def test_purchase_places_not_enough_places(client, setup_data):
+def test_cant_purchase_places_not_enough_places(client, setup_data):
     #TEST cant buy if not enough places
     competitions, _ = setup_data
     response = client.post('/purchasePlaces', data={
@@ -25,7 +25,7 @@ def test_purchase_places_not_enough_places(client, setup_data):
     assert b"Not enough places available." in response.data
     assert int(competitions[1]['numberOfPlaces']) == 5
 
-def test_purchase_places_more_than_12(client, setup_data):
+def test_cant_purchase_places_more_than_12(client, setup_data):
     #TEST cant buy more than 12 places
     competitions, _ = setup_data
     response = client.post('/purchasePlaces', data={
@@ -39,7 +39,7 @@ def test_purchase_places_more_than_12(client, setup_data):
     assert b"You cannot book more than 12 places per competition." in response.data
 
 
-def test_purchase_places_not_enough_points(client, setup_data):
+def test_cant_purchase_places_not_enough_points(client, setup_data):
     # TEST cant buy if not enough points
     _, clubs = setup_data
     response = client.post('/purchasePlaces', data={

tests/test_show_summary.py

@@ -14,3 +14,10 @@ def test_error_when_wrong_credentials(client, setup_data):
 
     assert response.status_code == 200
     assert b"Wrong credentials, please retry" in response.data
+
+def test_error_when_no_email(client, setup_data):
+    """TEST: No email inputed should redirect to index with an error message"""
+    response = client.post('/show_summary', data={'email': ''}, follow_redirects=True)
+
+    assert response.status_code == 200
+    assert b"Email is required. Please login." in response.data