Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Icon requests #164

Closed
basbebe opened this issue Jul 15, 2021 · 6 comments
Closed

Icon requests #164

basbebe opened this issue Jul 15, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@basbebe
Copy link
Contributor

basbebe commented Jul 15, 2021

Hi!

Would it be possible to add some of the following icons?

Thanks!

@Jean-Tinland Jean-Tinland added the enhancement New feature or request label Jul 15, 2021
@Jean-Tinland
Copy link
Owner

Hi!

It is certainly possible, but that's a lot of icons so I will add them progressively :)

@basbebe
Copy link
Contributor Author

basbebe commented Jul 18, 2021

I wouldn't have expected you to add them all at once, so thanks a lot already!

@kvndrsslr
Copy link
Contributor

What is the process for adding these icons? Do you manually create them using some vector art application or is there an automated way? I would love to contribute to this.

@Jean-Tinland
Copy link
Owner

Jean-Tinland commented Aug 11, 2021

@kvndrsslr
Thank you for proposing this, it would indeed be nice to have some help about these icons!

For each icon I'm following these steps:

  1. I'm getting the original icon or, if not in a vector format I'm redrawing it in Figma. No need to be extremely precise as it is displayed in a really small size)
  2. I'm setting the new icon in a 24x24 viewbox
  3. Then I'm optimising it using SVGOMG
  4. Finally I'm adding it to the icons.jsx file in order to make the association in app-icons.js

Let me know if this is clear enough :)

edit: typos

@kvndrsslr
Copy link
Contributor

I'll try this out for sure at the weekend, thanks for the instructions!

@Jean-Tinland
Copy link
Owner

It seems that everything is tracked in #189 , I'm closing this. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants