You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might not be a bug but by the design of browserify-shim. It should be mentioned in your docs that the output of react-components-gulp-tasks will not be A/UMD compatible.
I was able to successfully make a UMD build using webpack.
The text was updated successfully, but these errors were encountered:
pixeldrew
changed the title
Output dist doesn't work in AMD environments because of browserify standalone
Output dist doesn't work in AMD environments because of browserify-shim
Jun 24, 2015
I tried to rewrite this library to use https://github.com/eduardolundgren/gulp-umd instead of browserify-shim, but couldn't get it to work. I always end up with an empty file as dist-script.
I can however create a PR with what I have, maybe someone who is more experienced with node and gulp can tell me what I'm doing wrong.
browserify-shim incorrectly rewrites require('react') to (window.React).
in a new version of browserify-shim, it rewrites to this (which is still broken):
This might not be a bug but by the design of browserify-shim. It should be mentioned in your docs that the output of react-components-gulp-tasks will not be A/UMD compatible.
I was able to successfully make a UMD build using webpack.
The text was updated successfully, but these errors were encountered: