💥 (breaking) node 20, esm, semantic-release@23 [b] #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ESM Updates for Semantic Release
ci updates, package json and - [x] @types/node@20.11.5 - [x] tsup@8.0.1 - [x] turbo@1.11.3 - [x] typescript@5.3.3 BREAKING CHANGE: Drop Node 16 + 18; Only Node 20
Not the best commit message here ...
1 💩 (hack) tweaking to get local semantic-release working
JeromeFitz
changed the title
|
Have to do some localized testing, but should be merging this by end of weekend. 🎉 |
1 task
JeromeFitz
changed the title
kodiakhq bot
added a commit
to JeromeFitz/websites
that referenced
this pull request
Jan 21, 2024
## Packages ### Upgrades - `@jeromefitz/*` canary builds from: JeromeFitz/packages#1144 - `semantic-release@23` - `prettier@3` - `octokit/core` - `date-fns` - `upstash/redis` - `react-use` - `zustand` ### Removals - [x] `@radix-ui/*` internals ## Next + ESM Well ... this was a journey. Wanted to see about moving the following packages to be their own externals (module, esm, etc.): - `@jeromefitz/design-system` - `@jeromefitz/shared` - `next-notion` But ... then `next` in the current configuration _cannot_ import and keeps thinking everything is a `client` component on the `server`. This without an example I know is not helpful, but will try again on this to move to module stuff later. What this does is preps for that -- and also removes it, heh. But then focuses on `next` transpiling (sic) the worskpaces not importing them as an external. Changes to `postcss.config.cjs` C'est la vie. ## Breaking Is the fact everything is kind of re-written but also not ... but this is a more proper move to Node 20 - This detaches `jerandky` for the moment as well
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 20 & ESM
Node 20 Steps
ESM Update
A lot of
.jsand addingnode20.jsonfortsconfigSemantic Release 23
Other Packages Upgraded With:
More Package Upgrades
Remove ?:
semantic-release-commit-filterthis is needed from a peer deppnpm
Temporarily drop support for and look to deprecate where possible:
@jeromefitz/design-system=> Moving back to Tailwind elsewhere@jeromefitz/git-cz=> Long enough, prune code.