Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inspections for DrawGizmo callback parameters #36

Closed
citizenmatt opened this issue May 23, 2016 · 2 comments
Closed

Inspections for DrawGizmo callback parameters #36

citizenmatt opened this issue May 23, 2016 · 2 comments
Labels
up for grabs Good issues for external contributors
Milestone

Comments

@citizenmatt
Copy link
Member

citizenmatt commented May 23, 2016

Add inspections to ensure callback methods marked with the DrawGizmo attribute are defined with the correct parameters, e.g.

[DrawGizmo (GizmoType.Selected | GizmoType.Active)]
static void DrawGizmoForMyScript (MyScript scr, GizmoType gizmoType)

This must have two parameters, one object that is the target, and the second is GizmoType. The inspection should verify the type of the target object. (What is this type? MonoBehaviour? Component?)

@citizenmatt citizenmatt added this to the Backlog milestone Jul 3, 2018
@citizenmatt citizenmatt changed the title Inspections for callback parameters Inspections for DrawGizmo callback parameters Sep 5, 2018
@citizenmatt
Copy link
Member Author

Are there any other callback methods like this? Create new issues for each new callback type.

@citizenmatt citizenmatt added the up for grabs Good issues for external contributors label Sep 5, 2018
@JurjenBiewenga
Copy link
Contributor

I'd like to pick this issue up

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
up for grabs Good issues for external contributors
Projects
None yet
Development

No branches or pull requests

2 participants