Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Invalid warning for this == null on Unity objects #368

Closed
citizenmatt opened this issue Feb 20, 2018 · 2 comments
Closed

Invalid warning for this == null on Unity objects #368

citizenmatt opened this issue Feb 20, 2018 · 2 comments
Labels
resharper-engine-issue Affecting the backend (ReSharper) engine - e.g. C# analysis
Milestone
Rider 2018.2

Comments

@citizenmatt
Copy link
Member

Rider/ReSharper will warn that this == null is always false. This isn't true for Unity objects, as the custom equality operator can return false if the unmanaged C++ engine object has been destroyed.

This will ideally be fixed by a change in the ReSharper engine. See RSRP-468462
@citizenmatt citizenmatt added the resharper-engine-issue Affecting the backend (ReSharper) engine - e.g. C# analysis label Feb 20, 2018
@citizenmatt citizenmatt added this to the Rider 2018.1 milestone Feb 20, 2018
@citizenmatt
Copy link
Member Author

See also RIDER-11622

@citizenmatt
Copy link
Member Author

See also RSRP-468462 (fixed in branch)

@citizenmatt citizenmatt modified the milestones: Rider 2018.1, Rider 2018.2 Jun 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
resharper-engine-issue Affecting the backend (ReSharper) engine - e.g. C# analysis
Projects
None yet
Milestone
Rider 2018.2
Development

No branches or pull requests
1 participant
@citizenmatt