Fix issues with module resolution & config parsing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add alias resolution caching * do not add extension to resolved alias * support modules + directories with same name
|
@IlyaSemenov @fmal @tkodev @pmunin would you guys care to try |
Js-Brecht
force-pushed
the
opts-resolve-fixes
branch
from
8ae3048 to
99755d1
Compare
|
@Js-Brecht I can confirm that issue #1 and #3 is resolved with this PR. I've installed 1.0.3-rc1 and it works fine. |
|
@Js-Brecht just echoing the above - this resolved #1 for me! Both compiling to CJS and ES6, the extension has been dropped which is fine for my use case. |
|
Is there a reason why json5 package was chosen over the jsonc-parser that is used by the TypeScript itself? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
FIxes #2
Fixes #3