Skip to content

Paginator doesn't have accessor methods for page params #365

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
jaimeiniesta opened this issue Apr 8, 2020 · 0 comments
Open

Paginator doesn't have accessor methods for page params #365

jaimeiniesta opened this issue Apr 8, 2020 · 0 comments

Comments

@jaimeiniesta
Copy link

jaimeiniesta commented Apr 8, 2020

The README suggests the following can be done to customize the page parameters:

JsonApiClient::Paginating::Paginator.page_param = "number"
JsonApiClient::Paginating::Paginator.per_page_param = "size"

However, this fails because this paginator doesn't have accessor methods for these attributes:

/Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:4:in `<class:Paginator>': undefined method `class_attribute' for JsonApiClient::Paginating::Paginator:Class (NoMethodError)
Did you mean?  class_variables
               class_variable_get
               class_variable_set
               class
               alias_attribute
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:3:in `<module:Paginating>'
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:2:in `<module:JsonApiClient>'
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:1:in `<top (required)>'

The other paginator, NestedParamPaginator, does work can be customized like:

JsonApiClient::Paginating::NestedParamPaginator.page_param = "number"
JsonApiClient::Paginating::NestedParamPaginator.per_page_param = "size"
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant