Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support GitLabs MLFlow backend #43

Closed
freemin7 opened this issue Apr 4, 2024 · 1 comment · Fixed by #44
Closed

Support GitLabs MLFlow backend #43

freemin7 opened this issue Apr 4, 2024 · 1 comment · Fixed by #44
Assignees
Labels
bug Something isn't working

Comments

@freemin7
Copy link

freemin7 commented Apr 4, 2024

I got it sort of working in GitLab
Screenshot_20240404_160828

For that i needed to undo #36 locally.

And artifact uploading is currently broken due to it not being supported by the library. I have a patch for that too.

I see two paths forward i could see working:

  • Do an AbstractMLFlow of which GitLabMLFlow and DagshubFlow are implementations which diverge in how URI is calculated
  • Break how URI is calculated and change the internal structure of MLFlow to allow different endpoints based on arguments passed at the MLFlow struct creation
@pebeto
Copy link
Member

pebeto commented Apr 9, 2024

Hi.

mlflow contains two endpoints for external communication: /ajax-api and /api. As far as I understand, the /ajax-api only works in the graphical instances of the app, and /api for the REST server. There is a particular case in DagsHub, where the /api endpoint was removed by unknown reasons. I expected the possibility of this issue.

In my opinion, point 2 is a better option. We can add an argument like MLFlow(ajax_endpoint=...).

@pebeto pebeto added the bug Something isn't working label Apr 9, 2024
@pebeto pebeto self-assigned this Apr 9, 2024
@pebeto pebeto linked a pull request Apr 9, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants