Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Performance left on table by not skipping ahead to study start region #25

Open
alecloudenback opened this issue Jun 4, 2024 · 0 comments

Comments

@alecloudenback
Copy link
Member

Simpler codebase is nice. Expecting some performance regression due to

        while first(result).to < study_start
            popfirst!(result)
        end

In situations where from << to and we are doing some monthly study being able to avoid the extra work likely reduces computation time by a significant factor.

Originally posted by @MatthewCaseres in #24 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant