Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deprecated kw.data and nt.names #200

Closed
JeffFessler opened this issue Jun 26, 2021 · 3 comments
Closed

deprecated kw.data and nt.names #200

JeffFessler opened this issue Jun 26, 2021 · 3 comments

Comments

@JeffFessler
Copy link
Contributor

JeffFessler commented Jun 26, 2021

I'm getting a warning and an error on a nightly build:

 Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = #AxisArray#7 at core.jl:243 [inlined]

...

  type DataType has no field names
  Stacktrace:
    [1] getproperty(x::Type, f::Symbol)
      @ Base ./Base.jl:37
    [2] #s11#8
      @ ~/.julia/packages/AxisArrays/IFpjG/src/core.jl:244 [inlined]

The error is from this apparently deprecated use of nt.names:

@generated nt_to_axes(nt::NamedTuple) =

The warning is due to this apparently deprecated use of kw.data:

AxisArray(A; kw...) = AxisArray(A, nt_to_axes(kw.data)...)

Probably related to this:
JuliaLang/julia#39448

I'll made a PR, but I am a bit concerned about the long delays in the existing PRs, e.g., from @johnnychen94. He has even volunteered to help with maintenance here in one of his PRs but no reply in a month. I realize the package developers are probably super busy because they have created so many terrific packages.
So how about enabling some others to help and spread the work around? I'm also willing to help.

@johnnychen94
Copy link
Member

It is a little bit unpleasant with this package not receiving any basic maintenance when it is not working well in Julia 1.7. I understand that people here are busy so I kindly request a write permission to this repo so that I can bring it back to track.

cc: @mbauman @timholy

@johnnychen94
Copy link
Member

Granted kindly by @mbauman I'll switch to this package this weekend.

@johnnychen94
Copy link
Member

closed by #201

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants