feat(wsl): detect wsl

[pankgeorg]

Allows opening links in Windows' browser from wsl

[mortenpi]

This LGTM. I tested this on my Windows machine, and I can both repro the original problem and confirm that this seems to fix it.

[mortenpi]

This does a bunch of filesystem operations. In general, it would probably better to memoize this into a global I think. But in this case, we don't really call detectwsl that many times, so this seems fine to me as-is too.

[mortenpi]

Note: CI failure is persistent, but unrelated -- it looks like some weird linking issue with Julia 1.4 and MacOS. We should maybe just stop testing for some older Julia versions?

[pfitzseb]

I'd be more comfortable with some error handling. Thoughts on this?

Suggested change

	function detectwsl()
	Sys.islinux() &&
	isfile("/proc/sys/kernel/osrelease") &&
	occursin(r"Microsoft|WSL"i, read("/proc/sys/kernel/osrelease", String))
	end
	function detectwsl()
	Sys.islinux() || return false
	try
	return occursin(r"Microsoft|WSL"i, read("/proc/sys/kernel/osrelease", String))
	catch err
	@debug "Could not read /proc/sys/kernel/osrelease." exception=(err, catch_backtrace())
	end
	return false
	end

[pankgeorg]

Sure. I also just found out that there is a new way to do this: https://github.com/JuliaLang/julia/pull/57069/files

[pfitzseb]

Yeah, that's neat.

@static if isdefined(Sys, :detectwsl)
    const detectwsl = Sys.detectwsl
else
    # attribution
    function detectwsl()
        # We use the same approach as canonical/snapd do to detect WSL
        islinux() && (
            isfile("/proc/sys/fs/binfmt_misc/WSLInterop")
            || isdir("/run/WSL")
        )
    end
end

then?

[pankgeorg]

seems great!

[mortenpi]

I took the liberty up updating the PR with this.

N/A anymore