Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature properties are kinda broken #65

Open
rafaqz opened this issue May 1, 2023 · 1 comment
Open

Feature properties are kinda broken #65

rafaqz opened this issue May 1, 2023 · 1 comment

Comments

@rafaqz
Copy link
Member

rafaqz commented May 1, 2023

help?> GI.properties
  GeoInterface.properties(feat) => properties

  Retrieve the properties of feat. This can be any Iterable that behaves like an AbstractRow. Ensures
  backwards compatibility with GeoInterface version 0.

But here we return a Dict which doesn't have getproperty like an AbstractRow

However you can call getproperty on the feature itself as a workaround, its' just confusing - and we cant standardise code accross feature types.

@rafaqz rafaqz changed the title Feature properties are kina broken Feature properties are kinda broken May 1, 2023
@rafaqz
Copy link
Member Author

rafaqz commented May 3, 2023

Maybe we need a wrapper for Dict that defines getproperty, or a a different kind of dict. Or... we define a NamedTuple exactly frome the pass that gets the column names so its type stable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant