-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rethink @requires dependencies #476
Comments
I will second rethinking I might be misreading the code, but afaict, WebSockets isn't actually a hard dependency. So it should be in the If removing |
What is missing to get this merged? |
The startup time for Blink.jl almost entirely consists of the requires blocks here.
The WebSockets block is unnecessary because its a dependency anyway. Mux.jl is a small package that shares many dependencies. It's much faster to depend on it here than to include it in requires.
Blink.jl already depends on WebIO.jl - the code should just live in Blink.jl where it can be precompiled.
All up this reduces the package load time of Blink.jl (on my laptop) from 5 seconds to 1 second.
See: JuliaGizmos/Blink.jl#288
If people agree I can PR Blink and WebIO with the changes.
The text was updated successfully, but these errors were encountered: