Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix link to API in tutorial #19

Closed
VarshC opened this issue Sep 8, 2022 · 5 comments · Fixed by #23
Closed

Fix link to API in tutorial #19

VarshC opened this issue Sep 8, 2022 · 5 comments · Fixed by #23
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@VarshC
Copy link
Collaborator

VarshC commented Sep 8, 2022

image

The link to the API currently gives a '404 page not found error'. The API itself can be accessed, just not through this link.
@TheCedarPrince TheCedarPrince added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Sep 8, 2022
@dublinsubway
Copy link
Contributor

I can check docs for API links and fix that if maintainers are cool with that.

That's just the link to API docs, right?

@TheCedarPrince
Copy link
Member

TheCedarPrince commented Sep 19, 2022 •
edited
Loading

Hi @dublinsubway! Core maintainer here and I am very cool with you opening a pull request to fix this 😎 If you need any help, please let me know and I am happy to help you! Furthermore, inspired by you, I am going to create a contributing section for the documentation. Hope you have a great day and I look forward to checking out the PR!

P.S. If you want to hop on a call so I can help you on this, feel free to shoot me an email at jacobszelko@gmail.com and we can schedule a time to chat. :)

@dublinsubway dublinsubway mentioned this issue Sep 19, 2022
Merged
@dublinsubway
Copy link
Contributor

Awh, that's surprisingly nice! I'm a total beginner, so don't have to much hope. Thanks for welcoming!

Threw in a PR there, feel free to take a glance whenever you have time. Best of luck!

@TheCedarPrince
Copy link
Member

Haha, we all start somewhere and I was in your shoes once before so am happy to help! Added a PR review and great start! If you want to keep working on it together, happy to do so! And welcome to Julia land! 👋

@TheCedarPrince
Copy link
Member

Done - thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix heading, improve package handling in docs dublinsubway/OMOPCDMCohortCreator.jl
3 participants
@TheCedarPrince @VarshC @dublinsubway