Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression in go_benchmark #5517

Closed
magistere opened this issue Jan 24, 2014 · 5 comments
Closed

Regression in go_benchmark #5517

magistere opened this issue Jan 24, 2014 · 5 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Milestone

Comments

@magistere
Copy link
Contributor

go_benchmark time increased on ~30% from January, 15 to January, 22.
See http://speed.julialang.org/timeline/#/?exe=2,1,3&base=none&ben=go_benchmark&env=1&revs=200&equid=off

@JeffBezanson
Copy link
Member

The first regression around Jan 15-16 is "intentional" in that I added missing checks to mod and rem. The bigger regression around Jan 20 I'm not yet sure about.

@carlobaldassi
Copy link
Member

Bisect blames 7b60d50

@JeffBezanson
Copy link
Member

Just discovered the same thing. cc @timholy

@timholy
Copy link
Member

timholy commented Jan 25, 2014

Mostly a consequence of #5536. I had also called to_index twice on each index, doh! (Although that was much less important.)

@timholy
Copy link
Member

timholy commented Jan 25, 2014

Oh, and thanks for running git bisect. Between that and the profiler, it was trivial to figure out the problem(s).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

4 participants