Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Map with row function syntax #291 #292

Closed
wants to merge 2 commits into from

Conversation

davibarreira
Copy link

Addressing #290.

Enables row functions such as:

Map((row->row.a + row.b) => :NewColumnName)
Map(row->sum(row) => :NewColumnName)

This is just an exploration, so I did not fix the test for show.

@juliohm
Copy link
Member

juliohm commented Sep 18, 2024

Thank you @davibarreira for performing this experiment! I believe that this syntax is somewhat more limiting than the one we currently have. Does it perform much better if we rely on the Tables.rows directly?

@davibarreira
Copy link
Author

I haven't checked. I'll do some benchmarks to see if there is improvement.

@juliohm
Copy link
Member

juliohm commented Sep 19, 2024 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants