Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Return NaN #86

Closed
dmoored4 opened this issue Nov 2, 2021 · 2 comments
Closed

Return NaN #86

dmoored4 opened this issue Nov 2, 2021 · 2 comments

Comments

@dmoored4
Copy link

dmoored4 commented Nov 2, 2021

Would you be open to a pull request that allowed a user to specify bc="NaN" which would, as expected, return NaN instead of a throwing an error?

@kbarbary
Copy link
Collaborator

kbarbary commented Nov 3, 2021

Huh, I'm not sure. This isn't a feature of the Fortran library, and although this would be relatively minor, I'm hesitant to start adding pure-Julia features here. Effort adding pure-Julia features would probably be better spent in a package like Interpolations.jl.

It should be relatively easy for users to "add on" this functionality themselves by setting values outside the boundary knots (get_knots(spl)[[1,end]]) to NaN when evaluating.

I guess it depends whether this would be a widely used feature, which is a little hard to get a feeling for.

@dmoored4
Copy link
Author

dmoored4 commented Nov 8, 2021

Ok thanks for the rec to look towards Interpolations for Julia features. Makes sense that you want to keep this as.

@dmoored4 dmoored4 closed this as completed Nov 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants