Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for custom covariance estimation methods #80

Closed
mateuszbaran opened this issue Nov 30, 2018 · 3 comments
Closed

Support for custom covariance estimation methods #80

mateuszbaran opened this issue Nov 30, 2018 · 3 comments

Comments

@mateuszbaran
Copy link
Contributor

I'm currently working on LDA with custom covariance estimation methods. Would a PR about it be appropriate here? I've already started making this package: CovarianceEstimation.jl .
@wildart
Copy link
Collaborator

wildart commented Nov 30, 2018

Sounds interesting. Maybe, LDA model can be extended to accept different covariance estimation methods. You can start drafting PR where we can discuss details.

@mateuszbaran
Copy link
Contributor Author

OK, I'll make a PR once I'm relatively satisfied with my code.

@mateuszbaran mateuszbaran mentioned this issue Dec 27, 2018
Merged
@mateuszbaran
Copy link
Contributor Author

Fixed by #84

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wildart @mateuszbaran