Relative URL parsing

[c42f]

Should this package recognize "relative URLs" as described in https://www.ietf.org/rfc/rfc1808.txt?

Python's urllib.parse seems to do this — see https://docs.python.org/3/library/urllib.parse.html

[quinnj]

This repo hasn't been actively maintained for a while and should be archived; best off to file an issue at HTTP.jl where we have the URIs.jl module that has a bunch of update from this original code.

[c42f]

Excellent, it seems HTTP.URIs can already parse relative URIs.

Ideally I'd not have to depend on all of HTTP.jl just for some light URI parsing but for now it seems fine.

[quinnj]

There are plans to register URIs.jl module as its own package; I just haven't gotten around to it yet

[c42f]

Ah now I understand. I thought there were plans for this (based on some slack discussion a while back?) and I figured URIParser was the resulting package.

[c42f]

@quinnj I went ahead and extracted the URI parsing functionality from HTTP.jl, preserving the git history and fixing up various things to make sure the tests pass. Further cleanup could be done but for now I think this works ok.

https://github.com/c42f/URIs.jl

Would you like to move this to JuliaWeb?

[quinnj]

Yeah, that sounds good to me. I had wanted to try out actually leaving the code inside the HTTP.jl repo (as a subdirectory package) and registering it from there, but figuring out exactly how to do that has been the main blocker in doing it 😄 . The URIs.jl code is separate enough that I'm fine with it living as its own repo, but if you're up for just plopping that code into the HTTP.jl directory as a PR, I'd love to see if we can make that work.

[c42f]

Heh, I don't know how to do this either.

I found JuliaLang/Pkg.jl#1251 (comment) which contains some links to where the subdirs stuff was implemented.

Also as one working example, it seems SnoopCompile did this: https://github.com/timholy/SnoopCompile.jl/tree/master/SnoopCompileCore

Note that as a minor downside, if we put URLs as a subdir of HTTP and don't place HTTP in a subdir as well, HTTP will include the URLs source code as part of the package (even though it won't be used). cf. JuliaLang/Pkg.jl#1251 (comment)

[c42f]

Hmm. Reading through some of those issues it seems like using a subdir might be a fair amount of messing around without a lot of benefit at this point (JuliaLang/Pkg.jl#1251 (comment)).

Also there's CI to consider — do you want CI to be done separately or together?

Overall I get the vibe that it just might not be worth it at this point.

[quinnj]

Thanks for digging in; let's just move the URIs.jl repo to JuliaWeb (I invited you as a member, so you should be able to do it) and have it live as a separate package.

[c42f]

Oop done!

I had a little mishap with permissions (I forgot to accept your JuliaWeb invite before transferring) so you'll get some spam, sorry!