Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exposing vendored packages #16

Open
wholien opened this issue Jul 1, 2016 · 1 comment
Open

Exposing vendored packages #16

wholien opened this issue Jul 1, 2016 · 1 comment

Comments

@wholien
Copy link

wholien commented Jul 1, 2016

I'm getting this issue when using this package: http://stackoverflow.com/questions/38091816/packages-type-cannot-be-used-as-the-vendored-packages-type

It seems that because go-yelp uses the null package in defining structs, the vendored package is exposed and causing this issue. After thinking about it and talking with others, two potential solutions seem to be either 1) not vendoring the package at all, or 2) keeping the vendored package, but create public functions that can be accessed to create the structs defined in go-yelp.

Do you have any thoughts?

@salpalvv
Copy link

imported nicerobot's fork with the PR and the below is working

options := yelp.SearchOptions{
         GeneralOptions: &yelp.GeneralOptions{
             Term: "food",
         },
         CoordinateOptions: &yelp.CoordinateOptions{
             Latitude:  yelp.FloatFrom(latitude),
             Longitude: yelp.FloatFrom(longitude),
         },
      }

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants