From 571c83335ee757234ac1688b67488368bedffba2 Mon Sep 17 00:00:00 2001 From: Valery Bitsoev Date: Wed, 24 Jul 2024 17:26:38 +0200 Subject: [PATCH 1/2] Add an option to connect nulls to the timeseries --- timeseries/timeseries.go | 8 ++++++++ timeseries/timeseries_test.go | 9 +++++++++ 2 files changed, 17 insertions(+) diff --git a/timeseries/timeseries.go b/timeseries/timeseries.go index 1fc2a236..354253df 100644 --- a/timeseries/timeseries.go +++ b/timeseries/timeseries.go @@ -450,3 +450,11 @@ func FieldOverride(m fields.Matcher, opts ...fields.OverrideOption) Option { return nil } } + +func ConnectNulls(enabled bool) Option { + return func(timeseries *TimeSeries) error { + timeseries.Builder.TimeseriesPanel.FieldConfig.Defaults.Custom.SpanNulls = enabled + + return nil + } +} diff --git a/timeseries/timeseries_test.go b/timeseries/timeseries_test.go index a26974af..14890578 100644 --- a/timeseries/timeseries_test.go +++ b/timeseries/timeseries_test.go @@ -468,3 +468,12 @@ func TestValuesCanBeStacked(t *testing.T) { req.NoError(err) req.Equal("percent", panel.Builder.TimeseriesPanel.FieldConfig.Defaults.Custom.Stacking.Mode) } + +func TestConnectNullsCanBeConfigured(t *testing.T) { + req := require.New(t) + + panel, err := New("", ConnectNulls(true)) + + req.NoError(err) + req.Equal(true, panel.Builder.TimeseriesPanel.FieldConfig.Defaults.Custom.SpanNulls) +} From 8b085ee4c9aa96272eb40f556a51c4f492d8cef0 Mon Sep 17 00:00:00 2001 From: Valery Bitsoev Date: Wed, 24 Jul 2024 17:33:57 +0200 Subject: [PATCH 2/2] add doc string --- timeseries/timeseries.go | 1 + 1 file changed, 1 insertion(+) diff --git a/timeseries/timeseries.go b/timeseries/timeseries.go index 354253df..e3e6cb1c 100644 --- a/timeseries/timeseries.go +++ b/timeseries/timeseries.go @@ -451,6 +451,7 @@ func FieldOverride(m fields.Matcher, opts ...fields.OverrideOption) Option { } } +// ConnectNulls allow to connect lines with null values func ConnectNulls(enabled bool) Option { return func(timeseries *TimeSeries) error { timeseries.Builder.TimeseriesPanel.FieldConfig.Defaults.Custom.SpanNulls = enabled