Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove dependency on DepotDownloader #87

Open
AlphaKeks opened this issue Aug 7, 2024 · 0 comments
Open

Remove dependency on DepotDownloader #87

AlphaKeks opened this issue Aug 7, 2024 · 0 comments
Labels
refactor This is a change that will improve only the code itself, not any results of it

Comments

@AlphaKeks
Copy link
Collaborator

AlphaKeks commented Aug 7, 2024

  1. shelling out is gross
  2. it's yet another dependency you have to install
  3. it doesn't play nice with immutable file systems (e.g. docker images built by nix)

Ideally we implement the functionality we need (downloading workshop maps) directly as a Rust library, but it isn't obvious to me how DepotDownloader works just by looking at their code...

@AlphaKeks AlphaKeks added the refactor This is a change that will improve only the code itself, not any results of it label Aug 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactor This is a change that will improve only the code itself, not any results of it
Projects
None yet
Development

No branches or pull requests

1 participant