Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Latte 2.9 #178

Open
Pepiik opened this issue Nov 20, 2020 · 6 comments
Open

Latte 2.9 #178

Pepiik opened this issue Nov 20, 2020 · 6 comments

Comments

@Pepiik
Copy link

Pepiik commented Nov 20, 2020

Hello,
after update latte/latte to 2.9 from 2.8.3 getting this error:

Compile Error

Declaration of Kdyby\StrictObjects\Scream::__set(string $name, $value) must be compatible with Latte\Macros\MacroSet::__set(string $name, $value): void
@jkavalik
Copy link

jkavalik commented Nov 24, 2020

Could Kdyby\StrictObjects be instead replaced with Nette\SmartObject from nette/utils which is already required?

@dg
Copy link

dg commented Jan 7, 2021

The only correct fix is to removed use Kdyby\StrictObject\Scream here https://github.com/Kdyby/Translation/blob/master/src/Latte/TranslateMacros.php#L21

🤦‍♂️

@jaroslavlibal
Copy link

Unfortunately, there will probably be more compatibility issues than this one :(

Eg. it is not possible to use a paired translation macro (Undefined variable: ʟ_fi; however the same problem exists since latte 2.8.4).

@dg
Copy link

dg commented Jan 18, 2021

So why don't you fork it and fix it?

@jaroslavlibal
Copy link

Because I discovered it accidentally a few minutes before my post. I wasn't able to find out what needs to be changed before returning from work. I also did't know if I am able to solve it at all.

I thought it would be better to make a note to an already open issue called "Latte 2.9" than to create a new issue or doing nothing.

Your "strict answer" makes me feel that I am doing something bad and I don't think I deserved it.

PR: 4cf0f7b

@dg
Copy link

dg commented Jan 18, 2021

It is nothing against you, but that the problem is solved in two years. It's time to leave the dead horse.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants