-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Restoration of the formatter for KEY files #3494
base: main
Are you sure you want to change the base?
Conversation
Achieving auto-formatting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation / commenting at all.
b7dc229
to
d9a301b
Compare
@mattulbrich Looking in the test log shows, that not all KeY files in the repo are parsable anymore. |
CodeBuff could be interesting here: https://www.antlr.org/papers/codebuff.pdf |
This PR seems to also touch totally unrelated parts of the code. This is why it should not be merged as is. |
I only see the necessary changes, and a lot of changes that arise by the fact, that the main is running away (spotless indentation changes, etc.) |
7320163
to
97b2eda
Compare
public class CheckAll { | ||
@TestFactory | ||
public Stream<DynamicTest> checkAllKeYFiles() throws IOException { | ||
var s = Files.walk(Paths.get("..")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this check all .key files in and under the key main directory? That would seem too strict.
I have added some javadoc to the Wiesler files. |
Archeology: In the back old days, we reformatted all our KeY files.
If you need to restore a branch before that time to bring it on the master, you should also reformat the KeY files before the merging.
This PR brings the formatter written by Wiesler.
The original MR was !614.
Currently unclear, whether we want to bring this on the main.
Has Sonarqube activated for evaluation reason