Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[spirv-opt] Inlining pass generates OpVariable of PhysicalStorageBuffer pointer type without AliasedPointer decoration. #5607

Closed
csyonghe opened this issue Mar 11, 2024 · 2 comments · Fixed by #5635
Closed

[spirv-opt] Inlining pass generates OpVariable of PhysicalStorageBuffer pointer type without AliasedPointer decoration. #5607

csyonghe opened this issue Mar 11, 2024 · 2 comments · Fixed by #5635
Assignees
@jeremy-lunarg
Labels
component:optimization

Comments

@csyonghe
Copy link

csyonghe commented Mar 11, 2024 •
edited
Loading

If the source spirv contains a function that takes an AliasedPointer parameter, the --inline-entry-points-exhaustive pass generates a pointer-typed OpVariable without AliasedPointer decoration, which leads to validation error.

Steps to reproduce:
test.zip

Use the test.spv in test.zip file:

spirv-val test.spv       # passes validation
spirv-opt --inline-entry-points-exhaustive -o test-out.spv
spirv-val test-out.spv       # FAILS validation

spirv-val output:

error: line 121: OpVariable 131: expected AliasedPointer or RestrictPointer for PhysicalStorageBuffer pointer.
  %131 = OpVariable %_ptr_Function__ptr_PhysicalStorageBuffer_int Function
@csyonghe csyonghe mentioned this issue Mar 11, 2024
Closed
@jeremy-lunarg
Copy link
Contributor

@dneto0 I believe @greg-lunarg worked on this. We'd be happy to look at this bug. Please assign to me if you'd like.

@jeremy-lunarg
Copy link
Contributor

FYI, I have a fix for this incoming. Just wrapping up the test.

jeremy-lunarg added a commit to jeremy-lunarg/SPIRV-Tools that referenced this issue Apr 4, 2024
@jeremy-lunarg
Add AliasedPointer decoration
85db945 
Fix KhronosGroup#5607

When inlining, decorate return variable with AliasedPointer if the
storage class of the pointee type is PhysicalStorageBuffer.
@jeremy-lunarg jeremy-lunarg mentioned this issue Apr 4, 2024
Merged
jeremy-lunarg added a commit that referenced this issue Apr 5, 2024
@jeremy-lunarg
Add AliasedPointer decoration (#5635)
ade1f7c 
Fix #5607

When inlining, decorate return variable with AliasedPointer if the
storage class of the pointee type is PhysicalStorageBuffer.
@kaizhangNV kaizhangNV mentioned this issue Apr 9, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jeremy-lunarg jeremy-lunarg

Labels
component:optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add AliasedPointer decoration jeremy-lunarg/SPIRV-Tools
4 participants
@cassiebeckley @csyonghe @jeremy-lunarg @dneto0