-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for codified VUs #2081
base: main
Are you sure you want to change the base?
Conversation
One limitation I couldn't work around is the inability to get source location information during asciidoctor AST traversal. I backported the relevant feature to asciidoctor v2.0 here asciidoctor/asciidoctor#4417, and when landed and a new version released, needs an update in the docker image. In the meantime, I've made sure to output enough information so the offending VU (that's failing build) can be identified. |
652a0a9
to
1090955
Compare
Found a solution for this, so source location information is now present too: https://github.com/asciidoctor/asciidoctor-extensions-lab/blob/main/lib/enable-sourcemap-preprocessor.rb I did notice sometimes it's off by a few lines though 🤔 I also reworked this to use |
8e8dcc1
to
3a85a6b
Compare
Fixed some bugs + added comment support @oddhack, I want to disable two-line headers (that look like this:
asciidoctor's control for that is It turns out that feature makes line number tracking messed up in asciidoctor. |
The style guide says to use only the single-line '== Title' form although I do not know that the other form is never used anywhere. Easiest way to find out is generate HTML with and without this control and compare them, probably. |
The following is implemented in this change: - Codified VU parsing - Codified VU reformatting in source (reflow.py) - Codified VU formatting for build either in code or english - Codified VU type checking - Codified VU customization for build with/without extensions/versions * Removes the need for ifdef - Unit tests
441572b
to
1dfcb0b
Compare
The following is implemented in this change: