-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rename primitive in mesh/primitive to mode #341
Comments
@glome83 Thanks for bringing this to our attention, so as here: "primitives": [
{
"attributes": {
"NORMAL": "accessor_25",
"POSITION": "accessor_23",
"TEXCOORD_0": "accessor_27"
},
"indices": "accessor_21",
"material": "blinn3-fx",
"primitive": 4
}
] you suggest instead: "primitives": [
{
"attributes": {
"NORMAL": "accessor_25",
"POSITION": "accessor_23",
"TEXCOORD_0": "accessor_27"
},
"indices": "accessor_21",
"material": "blinn3-fx",
"mode": 4
}
] Which I don't have a strong opinion about this but I undertand that it could be less confusing - only concern here is I don't find @pjcozzi what do you think ? |
This probably better since "primitives/primitive" isn't used in two different contexts. Should I update the spec? |
@pjcozzi yeah, let's do it for 0.9 |
Updated the spec in 5bcf79e in the |
This can be closed when 1.0 is merged...or now. |
This is done in the |
There's a property named "primitive" in "mesh/primitive". This can lead to confusion. Rename it to "mode" as it is called in glDrawArrays etc.
The text was updated successfully, but these errors were encountered: