Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

react-router dependency is "stuck" #515

Closed
glasserc opened this issue Apr 12, 2018 · 2 comments
Closed

react-router dependency is "stuck" #515

glasserc opened this issue Apr 12, 2018 · 2 comments

Comments

@glasserc
Copy link
Contributor

From #433: upgrading react-router (and react-router-redux) is not currently possible because react-router was a major version upgrade that breaks us in many interesting ways.

For those of you following along at home, react-router is a major breaking change and it is still rippling through the ecosystem (since June 2017). In particular, we depend on react-router-redux whose current version is 5.0.0-alpha.9. I have a branch at https://github.com/glasserc/kinto-admin/tree/ethan-updates-everything where I tried to update react-router but didn't succeed, instead pulling what I could out and landing it as #440. I decided I would check react-router-redux periodically and once it had had a real release, I would try to update again. In the meantime, this comment suggests that there will be a mechanism available "eventually" that supports the old (i.e. current) way of doing things, but I don't know when to expect it. In the meantime, let's not upgrade react-router.

This issue will track just the react-router dependency, since it deserves its own issue.

@glasserc
Copy link
Contributor Author

One of the things that broke us previously was react-breadcrumbs. However, https://github.com/svenanders/react-breadcrumbs/issues/99 and robbestad/react-breadcrumbs#105 seem like they may have landed and resolved that, so maybe this is worth taking another swing at.

@magopian
Copy link
Contributor

This should be fixed/done in #567

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants