Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added the maintainers list #32

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Added the maintainers list #32

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a28500b
Added the maintainers list
eveyonline Oct 13, 2022
488f8b8
typo correction scenari
eveyonline Oct 21, 2022
facfa21
Deleted neghmurken from maintainers list
eveyonline Oct 21, 2022
e24bdef
Merge branch 'master' into eveyonline-should-skip-ci
eveyonline Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ on your project.

## Limitations

This tool can be used in the following scenarii :
This tool can be used in the following scenaro :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This tool can be used in the following scenaro :
This tool can be used in the following scenario :

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding wikiperia :

However, the modern plural of the Italian word scenario is scenari.

So the fix should be scenari IMHO (I originally meant to write the plural of scenario, hence the two i's, but it looks like I wrote it wrong).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I got it wrong, from the PR I didn't get there were multiple ones!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the modern plural of the Italian word scenario is scenari. (not in english)


- on a pull request. You created a branch from your base branch (identified as
`origin/master` as default, but this identification is configurable via CLI
Expand All @@ -104,7 +104,7 @@ range of commits.
should be a merge commit in order to identify all the changes that were brought
in this merge.

This tool can not be used for the following scenario :
This tool can not be used for the following scenari :

- on a merge without a merge commit. As the tool scans for the latest commit
when you're on the base branch, this latest commit should be a merge commit.
Expand All @@ -124,5 +124,9 @@ and then use `cargo` to launch the tool :
```bash
$ cargo run -- <ssc_options>
```

## Contribution guide
Also, see our [contributing guide](CONTRIBUTING.md).

## Maintainers
[nm2107](https://github.com/nm2107)
[jaljo](https://github.com/jaljo)