Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

startdate/enddate aren't picking up (optional) time part of the argument #8

Closed
dbkinder1 opened this issue Mar 9, 2020 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation Fixed Fixed the issue

Comments

@dbkinder1
Copy link

Assuming I've got the format right (as presented in the online examples), the tool is parsing the date, but not the time from the command line. (Notice the output from the command isn't picking up the time part of the -enddate argument.)

C:\Users\DAVID\Downloads\KoenZomers.Ring.Api>RingRecordingDownload.exe -out K:\RingVideos -username xxxxxxx  -password yyyyyyyyy -startdate 03-05-2020 00:00:00 -enddate 03-05-2020 11:17:00

Ring Recordings Download Tool v2.0.1 by Koen Zomers

Connecting to Ring services
Authenticating using refresh token from previous session
Downloading all historical events between Thursday 5 March 2020 00:00:00 and Thursday 5 March 2020 00:00:00
0 items found, downloading to K:\RingVideos
Done
@dbkinder1
Copy link
Author

dbkinder1 commented Mar 9, 2020

The problem is the argument parsing code only is looking at the first argument after the "-startdate" (which is the date) and because of the space between the date/time, it's not picking up the time part when parsing the datetime string. As a work-around I tried using

-startdate 2020-03-05T00:00:00 -enddate 2020-03-05T11:17:00

(to remove the space between date and time), and it worked fine and as expected.

@dbkinder1 dbkinder1 changed the title startdate/enddate aren't picking up time part of the argument startdate/enddate aren't picking up (optional) time part of the argument Mar 9, 2020
@KoenZomers KoenZomers self-assigned this Mar 12, 2020
@KoenZomers KoenZomers added the investigating Looking into it label Mar 12, 2020
@KoenZomers
Copy link
Owner

Very well noticed @dbkinder1! Thanks for sharing your workaround as well. Another option would be to wrap the date/time in (double or single) quotes, i.e.:

.\RingRecordingDownload.exe -username user@domain.com -password mysupersecretpassword -startdate '12-03-2020 16:15:00'

I'll update the samples in the tool to reflect this.

@KoenZomers KoenZomers added documentation Improvements or additions to documentation Fixed Fixed the issue and removed investigating Looking into it labels Mar 12, 2020
@KoenZomers
Copy link
Owner

Resolved in version 2.0.1.1. Thanks for your contribution!

@dbkinder1
Copy link
Author

Thanks @KoenZomers and for completeness you might update the images in https://github.com/KoenZomers/RingRecordingDownload/blob/master/README.md that are missing quoted date/time arguments. :)

BTW, by using your nice ring downloader, together with mp4joiner to glue the individual videos together, and ffmpeg to speed up the combined videos by 60x, I'm creating a timelapse of a 2-month long home construction project.

@KoenZomers
Copy link
Owner

Done!

Cool idea about the timelapse!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation Fixed Fixed the issue
Projects
None yet
Development

No branches or pull requests

2 participants