We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
We currently use CoinProtocol type as a error type:
fn try_from_coin_protocol(proto: CoinProtocol) -> Result<Self, MmError<CoinProtocol>>
while this looks like a misconception, we also lose the error reason because of that, for e.g.:
let token_addr = valid_addr_from_str(&contract_address).map_err(|_| CoinProtocol::ERC20 { // TODO: maybe add error description to this err (we're losing 'Invalid address checksum' here) platform: platform.clone(), contract_address, })?;
Let's create a true error type instead of using CoinProtocol and make it propagate lower errors (like Invalid address checksum.
Invalid address checksum
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Problem
We currently use CoinProtocol type as a error type:
while this looks like a misconception,
we also lose the error reason because of that, for e.g.:
Solution
Let's create a true error type instead of using CoinProtocol and make it propagate lower errors (like
Invalid address checksum
.The text was updated successfully, but these errors were encountered: