Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: optimize port forwarding for kusion apply #1169

Open
liu-hm19 opened this issue Jun 17, 2024 · 2 comments · May be fixed by #1224
Open

Feat: optimize port forwarding for kusion apply #1169

liu-hm19 opened this issue Jun 17, 2024 · 2 comments · May be fixed by #1224
Assignees
Labels
hacktoberfest kind/feature Categorizes issue or PR as related to a new feature pending-discussion
Milestone

Comments

@liu-hm19
Copy link
Contributor

What would you like to be added?

Please optimize the --port-forwarding flag for kusion apply command:

  • Support direct port forwarding to Pod instead of relying on K8s Service
  • Support customized the local forwarding port number

Why is this needed?

Current, the --port-forward flag only supports applications with K8s Service resources, and the local forwarding port number needs to be consistent with that of the Service, which may easily lead to conflicts.

@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 17, 2024
@liu-hm19 liu-hm19 self-assigned this Jun 17, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 17, 2024
@liu-hm19
Copy link
Contributor Author

If --port-forward flag needs to directly support the port forwarding of a Pod, users seems to need to specify the name of the Pod, unless the application resources contain only one Pod. Since the Spec does not include the labels/annotations to specify which Pod corresponds to the Workload, Kusion currently cannot recognize the Pod for port forwarding. Thus, I think we may need to first implement adding labels or annotations for the Pods corresponding to the Workload. cc @SparkYuan

@liu-hm19 liu-hm19 linked a pull request Jul 16, 2024 that will close this issue
@liu-hm19 liu-hm19 modified the milestones: v0.12.1, v0.13.0 Jul 31, 2024
@liu-hm19 liu-hm19 removed this from the v0.13.0 milestone Sep 23, 2024
@ffforest
Copy link
Contributor

2025 Q1

@ffforest ffforest added this to the v0.14.0 milestone Dec 10, 2024
@ffforest ffforest removed this from the v0.14.0 milestone Dec 24, 2024
@ffforest ffforest added this to the v0.14.0 milestone Jan 7, 2025
@ffforest ffforest modified the milestones: v0.14.0, v0.15.0 Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hacktoberfest kind/feature Categorizes issue or PR as related to a new feature pending-discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants