Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: remove deprecated function #876

Closed
wants to merge 2 commits into from
Closed

refactor: remove deprecated function #876

wants to merge 2 commits into from

Conversation

huylg
Copy link

@huylg huylg commented Apr 28, 2023

hi @L3MON4D3,

vim.pretty_print is deprecated so I have changed it to vim.print

@huylg
Copy link
Author

huylg commented Apr 28, 2023

note: tested at nvim nightly 0.10

@leiserfg
Copy link
Contributor

This is deprecated since 0.9 (current stable) so it's fine to change it in the master branch.

@L3MON4D3
Copy link
Owner

Ah, thank you 👍
Actually, right now we have compatibility down to nvim0.7 (and I don't think we need to break it for this), could you add something like this, such that 0.7 keeps working?

@L3MON4D3
Copy link
Owner

(I'll have to add a test later to catch this, they should be failing on this PR 😬)

@ssayin ssayin mentioned this pull request May 5, 2023
Merged
@L3MON4D3
Copy link
Owner

L3MON4D3 commented May 5, 2023

Superseded by #880😅

@L3MON4D3 L3MON4D3 closed this May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huylg @leiserfg @L3MON4D3