Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: add stop_cover as a quick action #159

Closed
menuet88 opened this issue Sep 2, 2022 · 7 comments
Closed

Feature: add stop_cover as a quick action #159

menuet88 opened this issue Sep 2, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@menuet88
Copy link

menuet88 commented Sep 2, 2022

Hello, I didn't find how to stop moving cover from quick actions. It looks like the stop action is not working. Is this really run service: cover.stop_cover ?
The "desired action" menu shows options like play and pause which are not for covers (or I'm wrong?). Maybe is a good idea to reduce this list to domain/service specific actions?
It is possible to check and fix cover stop action?

Best regards,
Menuet88

@LAB02-Admin
Copy link
Member

Hey @menuet88,

Yea the list should be reorganised :) And I'll look into the cover-stop action

@LAB02-Admin LAB02-Admin changed the title Feature: Feature: add stop_cover as a quick action Sep 8, 2022
@LAB02-Admin LAB02-Admin self-assigned this Sep 8, 2022
@LAB02-Admin LAB02-Admin added the enhancement New feature or request label Sep 8, 2022
@Egglestron
Copy link

The logs show that it calls media_stop and not cover_stop, indeed.
Would love to see this implemented!

Cheers!

@LAB02-Admin
Copy link
Member

@Egglestron
Copy link

Hmmm, the Stop action now acts as a Close action and is still labeled media_stop in the logs (version 2022.14.0 non beta)? Pretty weird.

@LAB02-Admin
Copy link
Member

That is weird, worked here. I'm rewriting the entire quickactions code; it'll fetch all services/actions dynamically instead of me hardcoding them, so that should fix this and add a bunch of new stuff as well. I'll let you know when that beta is ready.

@LAB02-Admin
Copy link
Member

I've re-released 2022.14.0 with what should be the fix, if you're bored you could test it (you can just run the installer, no need to uninstall):

https://github.com/LAB02-Research/HASS.Agent/releases/download/2022.14.0/HASS.Agent.Installer.exe

@Egglestron
Copy link

It works! Thanks. 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants