Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEAT]: Make window based work area offset togglable #1285

Closed
swebra opened this issue Feb 20, 2025 · 3 comments
Closed

[FEAT]: Make window based work area offset togglable #1285

swebra opened this issue Feb 20, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request i-will-definitely-work-on-this I'm definitely going to work on this because it impacts my workflow directly komorebic Related to the komorebic crate

Comments

@swebra
Copy link

swebra commented Feb 20, 2025

Eligibility

Individual Commercial Use License

Suggestion

Using my new found commercial license (yahoo! excited to support the project) to pull up the suggestion of exposing the apply_window_based_work_area_offset workspace setting via the CLI to make it set-able/togglable at runtime.

This has previously been suggested at the end of Q&A #952 (here and here), but those comments were not directly related to the original question and were made after the question was answered, so they may have been lost.

I think the use-case largely stems from a desired window size being content dependent, take a browser on an ultrawide monitor as an example. A more-reasonably-sized window afforded by window_based_work_area_offset is great in the general case of reading webpages, but when interacting with a spreadsheet through the browser, the full width may be desired.

Alternatives Considered

  1. Using the existing toggle-maximize to mock a "apply_window_based_work_area_offset": false (as suggested in the original comments)
    • Doesn't maintain gap configuration
    • Doesn't address the case where window_based_work_area_offset > 1
  2. Moving the window(s) to a new workspace where "apply_window_based_work_area_offset": false
    • Breaks the flow of "always have X content on Y workspace to be able to jump to it quickly with Z shortcut"
    • Requires an empty workspace on standby (though I'm not entirely sure if dynamically created workspaces can have "apply_window_based_work_area_offset": false set)
    • Just sort of feels inelegant
  3. Allowing the window_based_work_area_offset region to be resized via CLI similar to resize-axis
    • More complex than just hooking into the existing apply_window_based_work_area_offset toggle
    • As window_based_work_area_offset is currently set per-monitor, a naive implementation would be monitor-wide rather than for the one workspace
    • That granularity of control is certainly not needed in my case, so may not be worth the complexity.
@swebra swebra added the enhancement New feature or request label Feb 20, 2025
Copy link

Feature requests on this repository are only open to current GitHub sponsors on the $5/month tier and above, people with a valid individual commercial use license, and approved contributors.
This issue has been automatically closed until one of those pre-requisites can be validated.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Repository owner unlocked this conversation Feb 21, 2025
@LGUG2Z
Copy link
Owner

LGUG2Z commented Feb 21, 2025

Hi @swebra, thanks for opening this issue! I had actually sent an email out to your employer which purchased the license yesterday asking for the name of the person to associate the license with, I'm lucky you came to track me down first!

This feature request makes sense; I think komorebic toggle-window-based-work-area-offset is a command we can add in the next release.

@LGUG2Z LGUG2Z reopened this Feb 21, 2025
@LGUG2Z LGUG2Z self-assigned this Feb 21, 2025
@LGUG2Z LGUG2Z added i-will-definitely-work-on-this I'm definitely going to work on this because it impacts my workflow directly komorebic Related to the komorebic crate labels Feb 21, 2025
@LGUG2Z LGUG2Z closed this as completed in 30c22f5 Feb 21, 2025
@LGUG2Z
Copy link
Owner

LGUG2Z commented Feb 21, 2025

This will be in the next nightly and 0.1.35 when it is released

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request i-will-definitely-work-on-this I'm definitely going to work on this because it impacts my workflow directly komorebic Related to the komorebic crate
Projects
None yet
Development

No branches or pull requests

2 participants