Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should clones be able to start their own copy of a sound? #919

Closed
ericrosenbaum opened this issue Jan 25, 2018 · 2 comments
Closed

Should clones be able to start their own copy of a sound? #919

ericrosenbaum opened this issue Jan 25, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@ericrosenbaum
Copy link
Contributor

This PR, “Audio effects state for clones,” introduced a new behavior that need discussion and possible changes.

It is related to the behavior of a clone starting a sound when another clone or the parent sprite has already started that same sound. In 2.0, the sound restarts. After the above PR, a new copy of the sound starts playing (with the clone's effects settings applied).

Example:
If you have a sprite with the sound "happy song", and you run "forever [start sound happy song]", it will restart the sound every frame, creating a stuttering sound. This is true in both 2.0 and 3.0. However, in 3.0, if you create a bunch of clones, and run "when I start as a clone [start happy song]", the clones will all separately start their own copy of the song.

Upside: you can make music using clones that play the same sound at overlapping times with different audio effect settings (pitch, pan, volume).

Downside: you get a potentially very loud sound instead of a stuttering sound if you make a lot of clones that play a sound simultaneously.

We should consider how often this downside case would occur in existing projects, if possible.

@CatsAreFluffy
Copy link

I'd say that the old behavior is less intuitive, since why would all clones share one speaker?

@thisandagain thisandagain removed their assignment Feb 26, 2018
@thisandagain
Copy link
Contributor

Discussed! @ericrosenbaum will follow-up with changes. :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants