Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Function pointers should not be instrumented #10

Open
ilagunap opened this issue Mar 12, 2020 · 1 comment
Open

Function pointers should not be instrumented #10

ilagunap opened this issue Mar 12, 2020 · 1 comment
Labels
bug Something isn't working clang_plugin_branch

Comments

@ilagunap
Copy link
Member

This was incorrectly instrumented:

This line: fptr[idx_dst] = (*fine_volumes)(SAMRAI::pdat::CellIndex(*bi));
Became: fptr[idx_dst] = _FPC_CHECK_((*fine_volumes)(SAMRAI::pdat::CellIndex(* bi), ), 125, “..ineOperator.cxx”);

Here a function pointer is assigned to an array element.

@ilagunap ilagunap added bug Something isn't working clang_plugin_branch labels Mar 12, 2020
@ilagunap
Copy link
Member Author

The problem here is not that the function pointer was instrumented (it returns a double value, os it's fine). The problem is the extra comma "," that is added. Without a reproducible this is hard to fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working clang_plugin_branch
Projects
None yet
Development

No branches or pull requests

1 participant