audit silo objects for missing content in browser (and eventually misleading silodiff results)

[aowen87]

Some objects in Silo are not easily displayed by browser. Objects whose array lengths depend on values in other arrays within the object are a good example. DBmultimeshadj is one such object. I fixed it by following the same pattern as for DBcompoundarray and adding a special method, browser_DBGetMultimeshadj to load a multimesh adjacency object into browser. But, there are still some other objects we need to do this for. DBgroupel map is one. DBmrgtree may be one. There may be others too. All the cases need to be found and fixed.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 1538
Status: Resolved
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: audit silo objects for missing content in browser (and eventually misleading silodiff results)
Assigned to: Mark Miller
Category: -
Target version: 4.9.2
Author: Mark Miller
Start: 07/10/2013
Due date:
% Done: 100%
Estimated time: 10.00 hours
Created: 07/10/2013 12:26 pm
Updated: 12/04/2013 02:02 pm
Likelihood: 3 - Occasional
Severity: 5 - Very Serious
Found in version: 4.8
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
Some objects in Silo are not easily displayed by browser. Objects whose array lengths depend on values in other arrays within the object are a good example. DBmultimeshadj is one such object. I fixed it by following the same pattern as for DBcompoundarray and adding a special method, browser_DBGetMultimeshadj to load a multimesh adjacency object into browser. But, there are still some other objects we need to do this for. DBgroupel map is one. DBmrgtree may be one. There may be others too. All the cases need to be found and fixed.

Comments:
I have already fixed the multimeshadj object and most of the groupelmap object. I have completed the audit by eye-balling silo.h.in and stc.c file in browser. I did find a few other cases of missing data, again due to issues in browser implementation with displaying certain kinds of data structures. In this case, region_pnames member of several objects is missing. This is an array of strings the last pointer of which points to null. Browser's existing infrastructure doesn't handle that case well and so those data members are not being displayed (or diff'd). I have found and fixed all these cases in browser. I tested groupelmaps and mrgtrees by using rocket_silo.cxx and perturbing outputs for two different runs and then running browser on them to see the diffs.