Skip to content

DX: use a pre-commit hook to press commiters to ensure codestyle is consistent #49

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
hcientist opened this issue Sep 6, 2024 · 0 comments
Assignees

Comments

@hcientist
Copy link
Member

hcientist commented Sep 6, 2024

  1. do we really want a client-side pre-commit hook to enforce formatting? (maybe not because then we can't "save" our progress)
  2. definitely want something for when a PR is opened to either autoformat, or add a comment/error something that the requester should format their code before expecting the PR to be reviewed
  3. start by ensuring that the python black formatter is running for you in vscode, and figure out the commandline to make it run against all python files in the backend and open a pr to merge the formatted version
@hcientist hcientist converted this from a draft issue Sep 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants