Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[4.2][Bug] Fake subfields do not get saved #4111

Closed
tabacitu opened this issue Jan 22, 2022 · 2 comments
Closed

[4.2][Bug] Fake subfields do not get saved #4111

tabacitu opened this issue Jan 22, 2022 · 2 comments

Comments

@tabacitu
Copy link
Member

Bug report

What I did

Tried to edit the number_with_prefix fake field inside Monster, in the new scenarios we've created (Story, Cave, Hero) to test which subfields work inside the relationship field.

What I expected to happen

Fake subfields to work, to get saved.

What happened

Fake fields do NOT get saved when used as subfields:

(A) inside Caves (hasOne) it will not work, but not show any error either
2022-01-22 20 16 53

(B) inside Stories (hasMany) it will not work AND show a big fat error
2022-01-22 20 18 55
Screenshot 2022-01-22 at 20 27 43

(C) inside Heroes (belongsToMany with extra pivot attributes) I haven't tried it yet since the whole CRUD is broken at the moment


IMPORTANT: I'm not saying they must work. I'm saying they don't. Not sure we should do anything about this. Because that "anything" probably involves moving the fake field functionality from the CreateOperation and UpdateOperation to a CrudPanel trait. Which will be YET ANOTHER breaking change...

We need to talk about this one, think about it... analyze what's intuitive/useful and how/if we can proceed.

Is it a bug in the latest version of Backpack?

Happening both on 4.2 and on create-all-relations-at-same-time branches.

@tabacitu
Copy link
Member Author

Note - this wasn't a problem in repeatable. Fake fields there don't make sense. But now that we use them as real fields... they kind of do...

@tabacitu
Copy link
Member Author

tabacitu commented Feb 2, 2022

Fixed in #4129

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant