Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cryptography deprecation warning #305

Closed
meejah opened this issue Apr 28, 2021 · 5 comments · Fixed by #306
Closed

cryptography deprecation warning #305

meejah opened this issue Apr 28, 2021 · 5 comments · Fixed by #306

Comments

@meejah
Copy link
Collaborator

meejah commented Apr 28, 2021

Several integration tests are failing because cryptography > 3.0 issues warnings for Python2 being end-of-lifed. As these are printed to the console by default, the CLI commands no longer interact properly.

@meejah
Copy link
Collaborator Author

meejah commented Apr 28, 2021

(To be clear, this is a bug for other users too not just integration-tests)

@meejah meejah added this to the private-storage milestone Apr 30, 2021
@exarkun
Copy link
Member

exarkun commented May 3, 2021

I failed to reproduce this. Which tests? What kind of Python environment?

What I did observe is that pyOpenSSL 20.0.1 is not compatible with cryptography 2.9.2. Downgrading to pyOpenSSL 19.1.0 in my local virtualenv gives me a fully passing test suite.

@meejah
Copy link
Collaborator Author

meejah commented May 3, 2021

If I install master in a local 2.7 venv, running magic-folder produces this (I have python 2.7.16):

(venv) meejah@buyan:~/work/leastauthority/src/magic-folder$ magic-folder 
/home/meejah/work/leastauthority/src/magic-folder/venv/lib/python2.7/site-packages/OpenSSL/crypto.py:14: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.

@exarkun
Copy link
Member

exarkun commented May 4, 2021

Okay. I can't reproduce that either. Perhaps this doesn't affect master with the dependencies declared in master - instead it affects master with an upgraded cryptography? That seems consistent with the info here - master requires cryptography <3.0 and this issue description says the deprecation is about cryptography > 3.0.

@exarkun
Copy link
Member

exarkun commented May 4, 2021

But I can't actually run master with cryptography > 3.0 because pkg_resources gets angry:

pkg_resources.DistributionNotFound: The 'cryptography<3.0' distribution was not found and is required by magic-folder

meejah added a commit that referenced this issue May 4, 2021
#305 Ignore cryptography deprecation warning
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants