Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SET_TEXT_DROPSHADOW does the same thing as SET_TEXT_DROP_SHADOW #174

Closed
justalemon opened this issue May 24, 2024 · 1 comment
Closed

SET_TEXT_DROPSHADOW does the same thing as SET_TEXT_DROP_SHADOW #174

justalemon opened this issue May 24, 2024 · 1 comment
Labels
priority: p2 medium A bug that makes things unstable or a feature that has been requested for a while status: acknowledged We are aware of the bug or feature request type: bug This is a bug
Milestone
2.1.1 (prev 2.1)

Comments

@justalemon
Copy link
Member

justalemon commented May 24, 2024 •
edited
Loading

I noticed this issue now, but you assumed wrong. SET_TEXT_DROPSHADOW just does the same thing as SET_TEXT_DROP_SHADOW unless a non-positive value is passed as the 1st argument. The 2nd to 5th argument is marked as UNUSED_PARAM in commands_hud.cpp and the native implementation doesn't even use none of them. If the 1st arg is not positive, the drop shadows is removed for the next text draw.

I wish I noticed the wrong assumption before releasing any stable releases tbh...

Originally posted by @kagikn in #169 (comment)
@justalemon justalemon added type: bug This is a bug status: acknowledged We are aware of the bug or feature request priority: p2 medium A bug that makes things unstable or a feature that has been requested for a while labels May 24, 2024
@justalemon justalemon added this to the 2.1.1 (prev 2.1) milestone May 25, 2024
@justalemon
Copy link
Member Author

This commit has been reverted in e97053d and all 2.1 releases have been pulled.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
priority: p2 medium A bug that makes things unstable or a feature that has been requested for a while status: acknowledged We are aware of the bug or feature request type: bug This is a bug
Projects
None yet
Milestone
2.1.1 (prev 2.1)
Development

No branches or pull requests
1 participant
@justalemon