Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

<h2> fontsize smaller than <h3> inside breadcomb #384

Open
2ynn opened this issue Apr 11, 2024 · 3 comments
Open

<h2> fontsize smaller than <h3> inside breadcomb #384

2ynn opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
cleanup Housekeeping enhancement New feature or request layout Issue regards layout layer

Comments

@2ynn
Copy link
Collaborator

2ynn commented Apr 11, 2024

when nested under <div class="breadcomb-ctn"> <h2> gets smaller than <h3>, this gets confusing

screenshot_2024-04-10_23:53:55

style.css should be updated and headers adapted throughout

@2ynn 2ynn added enhancement New feature or request cleanup Housekeeping layout Issue regards layout layer labels Apr 11, 2024
@2ynn
Copy link
Collaborator Author

2ynn commented Oct 24, 2024

@oxgr did you already address this elsewhere ?

@oxgr
Copy link
Collaborator

oxgr commented Oct 24, 2024

i remember mentioning it in passing, but not in issue

culprit is

only 7 instances of .breadcomb-ctn, so it shouldn't have too many manual edits to fix

i'll get on this

@oxgr oxgr self-assigned this Oct 24, 2024
@oxgr
Copy link
Collaborator

oxgr commented Nov 15, 2024

issue seems a lot more complicated than i thought. the sizing comes directly from the css template. checked blame and it's unchanged.

.website-traffic-ctn h2, .curved-ctn h2, .past-day-statis h2, .email-ctn-round h2, .recent-post-title h2, .recent-items-title h2, .realtime-title h2, .contact-hd h2, .animation-ctn-hd h2, .alert-hd h2, .color-hd h2, .tab-hd h2, .wizard-hd h2, .dropdown-trig-hd h2, .modals-hd h2, .accordion-hd h2, .tooltips-hd h2, .popovers-hd h2, .typography-list h2, .typography-heading h2, .typography-in-hd h2, .tpgp-hp-hd h2, .view-mail-hrd h2, .multiupload-sys h2, .basic-tb-hd h2{
font-size:20px;
color:#333;
}

i count a few dozen <h2> tags altogether. with templates splitting up nesting, all would have to get checked.

thing is i'm not exactly sure whether to just remove these css rules or set it to a different static size.

what do you think?


sidenote: gets more complicated since some h1 and h3 are also resized in the same file - sizes vary from 14-18px. some classes match the naming schemes of h2 rules, so they may be designed to go together. though, as far as i've checked, we dont use any of the affected h1/``h3` classes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cleanup Housekeeping enhancement New feature or request layout Issue regards layout layer
Projects
None yet
Development

No branches or pull requests

2 participants