From be7d6e421ec934e714f03bc4d5435589b22f2f76 Mon Sep 17 00:00:00 2001 From: Vincent Weevers Date: Sat, 11 Sep 2021 10:25:00 +0200 Subject: [PATCH] Set MACOSX_DEPLOYMENT_TARGET to 10.7, same as Node.js 10.x --- README.md | 2 +- binding.gyp | 3 ++- deps/leveldb/leveldb.gyp | 2 +- deps/snappy/snappy.gyp | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index efc5da1c..559bee19 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ We aim to support _at least_ Active LTS and Current Node.js releases, Electron 5 The `leveldown` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android and Alpine (musl) and is known to work on: - **Linux** (including ARM platforms such as Raspberry Pi and Kindle) -- **Mac OS** (10.10 and later) +- **Mac OS** (10.7 and later) - **Solaris** (SmartOS & Nodejitsu) - **FreeBSD** - **Windows** diff --git a/binding.gyp b/binding.gyp index 7dc3cd92..4719971d 100644 --- a/binding.gyp +++ b/binding.gyp @@ -26,7 +26,8 @@ "GCC_SYMBOLS_PRIVATE_EXTERN": "YES", # Set minimum target version because we're building on newer - "MACOSX_DEPLOYMENT_TARGET": "10.10", + # Same as https://github.com/nodejs/node/blob/v10.0.0/common.gypi#L416 + "MACOSX_DEPLOYMENT_TARGET": "10.7", # Build universal binary to support M1 (Apple silicon) "OTHER_CFLAGS": [ diff --git a/deps/leveldb/leveldb.gyp b/deps/leveldb/leveldb.gyp index 57c9cbcd..621d7e51 100644 --- a/deps/leveldb/leveldb.gyp +++ b/deps/leveldb/leveldb.gyp @@ -156,7 +156,7 @@ ], # Set minimum target version because we're building on newer - "MACOSX_DEPLOYMENT_TARGET": "10.10", + "MACOSX_DEPLOYMENT_TARGET": "10.7", # Build universal binary to support M1 (Apple silicon) "OTHER_CFLAGS": [ diff --git a/deps/snappy/snappy.gyp b/deps/snappy/snappy.gyp index 12e5a25d..e1653588 100644 --- a/deps/snappy/snappy.gyp +++ b/deps/snappy/snappy.gyp @@ -75,7 +75,7 @@ ], # Set minimum target version because we're building on newer - "MACOSX_DEPLOYMENT_TARGET": "10.10", + "MACOSX_DEPLOYMENT_TARGET": "10.7", # Build universal binary to support M1 (Apple silicon) "OTHER_CFLAGS": [