fix: gpu support for rp Dockerfile #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
alvin-reyes
reviewed
Aug 24, 2024
| FROM base AS build-gpu | ||
| RUN nvcc --version && nvcc --ptx -o ./pkg/resourceprovider/cudaminer/keccak.ptx ./pkg/resourceprovider/cudaminer/keccak.cu | ||
| RUN go build -v --tags cuda | ||
| ENV DISABLE_POW=false |
There was a problem hiding this comment.
Why did we need to set the DISABLE_POW here?
There was a problem hiding this comment.
This gets passed to lilypad resource-provider as --disable-pow (we disable pow for CPU ... i.e. local dev / integration tests)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Our published docker image didn't support nvidia gpus for the PoW calculations. This update modifies the Dockerfile to have a
COMPUTE_MODEbuild arg that allowsgpuorcpu(withgpuas the default). For non-gpu machines (local dev, integration tests) it usescpuin thedocker-compose.dev.ymlfile.Task/Issue reference
Closes: https://github.com/Lilypad-Tech/internal/issues/199