-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: preflight check for bacalhau version #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out, works great! ✨
Left a few comments on the error messages and limiting visibility to the bacalhau
package.
One other thing, seeing some noisy logs at start up:
2024/09/09 11:23:27 [DEBUG] GET http://localhost:1234/api/v1/agent/alive
2024/09/09 11:23:27 [ERR] GET http://localhost:1234/api/v1/agent/alive request failed: Get "http://localhost:1234/api/v1/agent/alive": dial tcp [::1]:1234: connect: connection refused
2024/09/09 11:23:27 [DEBUG] GET http://localhost:1234/api/v1/agent/alive: retrying in 1s (4 left)
2024/09/09 11:23:28 [ERR] GET http://localhost:1234/api/v1/agent/alive request failed: Get "http://localhost:1234/api/v1/agent/alive": dial tcp [::1]:1234: connect: connection refused
2024/09/09 11:23:28 [DEBUG] GET http://localhost:1234/api/v1/agent/alive: retrying in 2s (3 left)
2024/09/09 11:23:30 [ERR] GET http://localhost:1234/api/v1/agent/alive request failed: Get "http://localhost:1234/api/v1/agent/alive": dial tcp [::1]:1234: connect: connection refused
2024/09/09 11:23:30 [DEBUG] GET http://localhost:1234/api/v1/agent/alive: retrying in 4s (2 left)
2024/09/09 11:23:34 [DEBUG] GET http://localhost:1234/api/v1/agent/version
Are these coming from retryablehttp
? Could we suppress them?
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
They are, yeah. I think |
Summary
Introduces a pre-flight check for resource-provider to check that bacalhau is running and a currently supported version (
1.3.2
).Task/Issue reference
Closes: #280
Test plan