Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add solver HTTP tracing #388

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Sep 25, 2024

Summary

This pull request makes the following changes:

  • Add solver telemetry config and tracer
  • Add gorilla/mux/otelmux middleware to solver HTTP router

The pull request adds OpenTelemetry autoinstrumentation to the solver's HTTP router. It uses our existing tracer provider to send traces to our existing observability infrastructure.

Task/Issue reference

Closes: #387

Test plan

Start the observability stack (https://github.com/Lilypad-Tech/observability) with:

./stack observe-up dev

Start the stack and run a job. Open the observability dashboard at localhost:3000 and run a TraceQL query like:

{resource.service.name="solver" && span.http.method="GET"}

@bgins bgins force-pushed the bgins/feat-add-solver-mux-tracing branch from 7192be8 to e744c44 Compare September 25, 2024 22:07
@bgins bgins marked this pull request as ready for review September 25, 2024 22:08
@bgins bgins requested a review from a team as a code owner September 25, 2024 22:08
@bgins bgins changed the title feat: add solver HTTP tracing feat: Add solver HTTP tracing Sep 25, 2024
Copy link
Collaborator

@walkah walkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and I see HTTP traces from the solver ✅

@bgins bgins merged commit 88fe924 into main Sep 26, 2024
4 checks passed
@bgins bgins deleted the bgins/feat-add-solver-mux-tracing branch September 26, 2024 17:47
@bgins bgins self-assigned this Dec 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solver HTTP traces
3 participants